From 34d49d884c5fc639204d0e464455e0d898a987e4 Mon Sep 17 00:00:00 2001
From: Alex Ning <chineseperson5@gmail.com>
Date: Sun, 23 Jun 2019 17:53:30 +0800
Subject: Set onClickListener in ViewHolder instead of onBindViewHolder in
 CommentRecyclerViewAdapter. Do nothing when failing to vote comments.

---
 .../res/layout/item_is_loading_more_comments.xml   | 26 -------------------
 .../main/res/layout/item_load_more_comments.xml    | 27 --------------------
 .../res/layout/item_load_more_comments_failed.xml  | 29 ----------------------
 .../layout/item_load_more_comments_placeholder.xml | 27 ++++++++++++++++++++
 4 files changed, 27 insertions(+), 82 deletions(-)
 delete mode 100644 app/src/main/res/layout/item_is_loading_more_comments.xml
 delete mode 100644 app/src/main/res/layout/item_load_more_comments.xml
 delete mode 100644 app/src/main/res/layout/item_load_more_comments_failed.xml
 create mode 100644 app/src/main/res/layout/item_load_more_comments_placeholder.xml

(limited to 'app/src/main/res')

diff --git a/app/src/main/res/layout/item_is_loading_more_comments.xml b/app/src/main/res/layout/item_is_loading_more_comments.xml
deleted file mode 100644
index 7dfdf5cb..00000000
--- a/app/src/main/res/layout/item_is_loading_more_comments.xml
+++ /dev/null
@@ -1,26 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<com.google.android.material.card.MaterialCardView xmlns:android="http://schemas.android.com/apk/res/android"
-    android:layout_width="match_parent"
-    android:layout_height="wrap_content">
-
-    <LinearLayout
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content">
-
-        <View
-            android:id="@+id/vertical_block_item_is_loading_more_comments"
-            android:layout_width="0dp"
-            android:layout_height="match_parent"
-            android:background="@color/textColorPrimaryDark" />
-
-        <TextView
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:gravity="center"
-            android:padding="8dp"
-            android:text="@string/loading"
-            android:textColor="@color/primaryTextColor" />
-
-    </LinearLayout>
-
-</com.google.android.material.card.MaterialCardView>
\ No newline at end of file
diff --git a/app/src/main/res/layout/item_load_more_comments.xml b/app/src/main/res/layout/item_load_more_comments.xml
deleted file mode 100644
index 5b92d767..00000000
--- a/app/src/main/res/layout/item_load_more_comments.xml
+++ /dev/null
@@ -1,27 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<com.google.android.material.card.MaterialCardView xmlns:android="http://schemas.android.com/apk/res/android"
-    android:layout_width="match_parent"
-    android:layout_height="wrap_content">
-
-    <LinearLayout
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content">
-
-        <View
-            android:id="@+id/vertical_block_item_load_more_comments"
-            android:layout_width="0dp"
-            android:layout_height="match_parent"
-            android:background="@color/textColorPrimaryDark" />
-
-        <TextView
-            android:id="@+id/load_more_comments_text_view_item_load_more_comments"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:gravity="center"
-            android:padding="8dp"
-            android:text="@string/comment_load_more_comments"
-            android:textColor="@color/primaryTextColor" />
-
-    </LinearLayout>
-
-</com.google.android.material.card.MaterialCardView>
\ No newline at end of file
diff --git a/app/src/main/res/layout/item_load_more_comments_failed.xml b/app/src/main/res/layout/item_load_more_comments_failed.xml
deleted file mode 100644
index eb1b4e4f..00000000
--- a/app/src/main/res/layout/item_load_more_comments_failed.xml
+++ /dev/null
@@ -1,29 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<com.google.android.material.card.MaterialCardView xmlns:android="http://schemas.android.com/apk/res/android"
-    android:layout_width="match_parent"
-    android:layout_height="wrap_content">
-
-    <LinearLayout
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content">
-
-        <View
-            android:id="@+id/vertical_block_item_load_more_comments_failed"
-            android:layout_width="0dp"
-            android:layout_height="match_parent"
-            android:background="@color/textColorPrimaryDark" />
-
-        <TextView
-            android:id="@+id/retry_text_view_item_load_more_comments_failed"
-            android:layout_width="0dp"
-            android:layout_height="wrap_content"
-            android:layout_weight="1"
-            android:layout_gravity="center_vertical"
-            android:gravity="center"
-            android:padding="8dp"
-            android:text="@string/comment_load_more_comments_failed"
-            android:textColor="@color/primaryTextColor" />
-
-    </LinearLayout>
-
-</com.google.android.material.card.MaterialCardView>
\ No newline at end of file
diff --git a/app/src/main/res/layout/item_load_more_comments_placeholder.xml b/app/src/main/res/layout/item_load_more_comments_placeholder.xml
new file mode 100644
index 00000000..601a30d6
--- /dev/null
+++ b/app/src/main/res/layout/item_load_more_comments_placeholder.xml
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="utf-8"?>
+<com.google.android.material.card.MaterialCardView xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content">
+
+    <LinearLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content">
+
+        <View
+            android:id="@+id/vertical_block_item_load_more_comments"
+            android:layout_width="0dp"
+            android:layout_height="match_parent"
+            android:background="@color/textColorPrimaryDark" />
+
+        <TextView
+            android:id="@+id/placeholder_text_view_item_load_more_comments"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:gravity="center"
+            android:padding="8dp"
+            android:text="@string/comment_load_more_comments"
+            android:textColor="@color/primaryTextColor" />
+
+    </LinearLayout>
+
+</com.google.android.material.card.MaterialCardView>
\ No newline at end of file
-- 
cgit v1.2.3