From bde2220d91774337fba60cfdcc4324005b878736 Mon Sep 17 00:00:00 2001 From: Alex Ning Date: Sat, 18 Apr 2020 11:34:43 +0800 Subject: Remove unused attributes. Fix loading images using GlideImageGetter after the activity is destroyed. --- app/src/main/res/layout/activity_account_posts.xml | 2 -- app/src/main/res/layout/activity_account_saved_thing.xml | 6 ------ app/src/main/res/layout/activity_comment.xml | 6 +----- app/src/main/res/layout/activity_create_multi_reddit.xml | 7 ++----- .../main/res/layout/activity_custom_theme_listing.xml | 1 - app/src/main/res/layout/activity_customize_theme.xml | 2 +- app/src/main/res/layout/activity_edit_comment.xml | 2 -- app/src/main/res/layout/activity_edit_multi_reddit.xml | 7 ++----- app/src/main/res/layout/activity_edit_post.xml | 5 +---- app/src/main/res/layout/activity_filtered_thing.xml | 2 -- app/src/main/res/layout/activity_login.xml | 2 -- app/src/main/res/layout/activity_main.xml | 4 +--- .../main/res/layout/activity_multi_reddit_listing.xml | 2 -- app/src/main/res/layout/activity_post_image.xml | 16 +++------------- app/src/main/res/layout/activity_post_link.xml | 14 +++----------- app/src/main/res/layout/activity_post_text.xml | 14 +++----------- app/src/main/res/layout/activity_post_video.xml | 16 +++------------- app/src/main/res/layout/activity_rules.xml | 2 -- app/src/main/res/layout/activity_search.xml | 2 -- app/src/main/res/layout/activity_search_result.xml | 8 +------- .../res/layout/activity_search_subreddits_result.xml | 2 -- app/src/main/res/layout/activity_selected_subreddits.xml | 2 -- app/src/main/res/layout/activity_settings.xml | 4 +--- app/src/main/res/layout/activity_subreddit_selection.xml | 2 -- .../activity_subscribed_subreddits_multiselection.xml | 2 -- .../res/layout/activity_subscribed_thing_listing.xml | 6 ------ app/src/main/res/layout/activity_view_message.xml | 2 -- .../res/layout/activity_view_multi_reddit_detail.xml | 2 -- app/src/main/res/layout/activity_view_post_detail.xml | 3 --- app/src/main/res/layout/activity_view_sidebar.xml | 2 -- .../main/res/layout/activity_view_subreddit_detail.xml | 9 +-------- app/src/main/res/layout/activity_view_user_detail.xml | 9 +-------- app/src/main/res/layout/app_bar_main.xml | 7 ------- app/src/main/res/layout/fragment_flair_bottom_sheet.xml | 1 - app/src/main/res/layout/fragment_theme_preview_posts.xml | 3 +-- app/src/main/res/layout/item_comment.xml | 3 --- app/src/main/res/layout/item_footer_error.xml | 1 - app/src/main/res/layout/item_load_comments.xml | 1 - .../res/layout/item_load_more_comments_placeholder.xml | 1 - app/src/main/res/layout/item_nav_drawer_divider.xml | 3 +-- app/src/main/res/layout/item_post.xml | 15 --------------- app/src/main/res/layout/item_post_compact.xml | 16 +--------------- app/src/main/res/layout/item_post_detail.xml | 15 --------------- app/src/main/res/layout/item_subreddit_listing.xml | 1 - app/src/main/res/layout/item_user_listing.xml | 1 - 45 files changed, 27 insertions(+), 206 deletions(-) (limited to 'app/src/main/res/layout') diff --git a/app/src/main/res/layout/activity_account_posts.xml b/app/src/main/res/layout/activity_account_posts.xml index 695384d5..0cf8d0ef 100644 --- a/app/src/main/res/layout/activity_account_posts.xml +++ b/app/src/main/res/layout/activity_account_posts.xml @@ -4,7 +4,6 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" - android:background="?attr/backgroundColor" android:id="@+id/coordinator_layout_account_posts_activity" tools:context=".Activity.AccountPostsActivity"> @@ -12,7 +11,6 @@ android:id="@+id/appbar_layout_account_posts_activity" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?attr/toolbarAndTabBackgroundColor" android:theme="@style/AppTheme.AppBarOverlay"> @@ -12,7 +11,6 @@ android:id="@+id/appbar_layout_account_saved_thing_activity" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?attr/toolbarAndTabBackgroundColor" android:theme="@style/AppTheme.AppBarOverlay"> diff --git a/app/src/main/res/layout/activity_comment.xml b/app/src/main/res/layout/activity_comment.xml index a9af4118..33b9cfc3 100644 --- a/app/src/main/res/layout/activity_comment.xml +++ b/app/src/main/res/layout/activity_comment.xml @@ -5,14 +5,12 @@ android:id="@+id/coordinator_layout_comment_activity" android:layout_width="match_parent" android:layout_height="match_parent" - android:background="?attr/backgroundColor" tools:application=".CommentActivity"> + android:layout_marginBottom="16dp" /> + android:layout_height="1dp" /> + android:layout_height="1dp"/> + android:layout_height="1dp" /> + android:layout_height="1dp" /> + android:layout_height="1dp" /> + android:id="@+id/navigation_view_main_activity"> diff --git a/app/src/main/res/layout/activity_post_image.xml b/app/src/main/res/layout/activity_post_image.xml index e4a21951..8360f4b9 100644 --- a/app/src/main/res/layout/activity_post_image.xml +++ b/app/src/main/res/layout/activity_post_image.xml @@ -5,14 +5,12 @@ android:id="@+id/coordinator_layout_post_image_activity" android:layout_width="match_parent" android:layout_height="match_parent" - android:background="?attr/backgroundColor" tools:application=".PostImageActivity"> + android:layout_height="1dp" /> @@ -108,7 +104,6 @@ android:textColor="?attr/primaryTextColor" android:textSize="?attr/font_default" app:lib_setRadius="3dp" - app:lib_setRoundedBorderColor="?attr/spoilerColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -122,7 +117,6 @@ android:textColor="?attr/primaryTextColor" android:textSize="?attr/font_default" app:lib_setRadius="3dp" - app:lib_setRoundedBorderColor="?attr/nsfwColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -131,8 +125,7 @@ + android:layout_height="1dp" /> + android:layout_height="1dp" /> + android:layout_height="1dp" /> @@ -108,7 +104,6 @@ android:textColor="?attr/primaryTextColor" android:textSize="?attr/font_default" app:lib_setRadius="3dp" - app:lib_setRoundedBorderColor="?attr/spoilerColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -122,7 +117,6 @@ android:textColor="?attr/primaryTextColor" android:textSize="?attr/font_default" app:lib_setRadius="3dp" - app:lib_setRoundedBorderColor="?attr/nsfwColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -131,8 +125,7 @@ + android:layout_height="1dp" /> + android:layout_height="1dp" /> + android:layout_height="1dp" /> @@ -108,7 +104,6 @@ android:textColor="?attr/primaryTextColor" android:textSize="?attr/font_default" app:lib_setRadius="3dp" - app:lib_setRoundedBorderColor="?attr/spoilerColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -122,7 +117,6 @@ android:textColor="?attr/primaryTextColor" android:textSize="?attr/font_default" app:lib_setRadius="3dp" - app:lib_setRoundedBorderColor="?attr/nsfwColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -131,8 +125,7 @@ + android:layout_height="1dp" /> + android:layout_height="1dp" /> + android:layout_height="1dp" /> @@ -108,7 +104,6 @@ android:textColor="?attr/primaryTextColor" android:textSize="?attr/font_default" app:lib_setRadius="3dp" - app:lib_setRoundedBorderColor="?attr/spoilerColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -122,7 +117,6 @@ android:textColor="?attr/primaryTextColor" android:textSize="?attr/font_default" app:lib_setRadius="3dp" - app:lib_setRoundedBorderColor="?attr/nsfwColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -131,8 +125,7 @@ + android:layout_height="1dp" /> + android:layout_height="1dp" /> + android:id="@+id/coordinator_layout_search_result_activity"> diff --git a/app/src/main/res/layout/activity_search_subreddits_result.xml b/app/src/main/res/layout/activity_search_subreddits_result.xml index 183104b1..eaa560e7 100644 --- a/app/src/main/res/layout/activity_search_subreddits_result.xml +++ b/app/src/main/res/layout/activity_search_subreddits_result.xml @@ -5,14 +5,12 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:id="@+id/coordinator_layout_search_subreddits_result_activity" - android:background="?attr/backgroundColor" tools:application=".SearchSubredditsResultActivity"> @@ -12,7 +11,6 @@ android:id="@+id/appbar_layout_selected_subreddits_activity" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?attr/toolbarAndTabBackgroundColor" android:theme="@style/AppTheme.AppBarOverlay"> + android:layout_height="match_parent"> diff --git a/app/src/main/res/layout/activity_view_message.xml b/app/src/main/res/layout/activity_view_message.xml index 46c94f3a..f5f1c4e5 100644 --- a/app/src/main/res/layout/activity_view_message.xml +++ b/app/src/main/res/layout/activity_view_message.xml @@ -5,14 +5,12 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:id="@+id/coordinator_layout_view_message_activity" - android:background="?attr/backgroundColor" tools:context=".Activity.ViewMessageActivity"> diff --git a/app/src/main/res/layout/activity_view_sidebar.xml b/app/src/main/res/layout/activity_view_sidebar.xml index 113dd273..301b04cc 100644 --- a/app/src/main/res/layout/activity_view_sidebar.xml +++ b/app/src/main/res/layout/activity_view_sidebar.xml @@ -5,14 +5,12 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:id="@+id/coordinator_layout_view_sidebar_activity" - android:background="?attr/backgroundColor" tools:context=".Activity.ViewSidebarActivity"> + android:layout_below="@id/banner_image_view_view_subreddit_detail_activity"> diff --git a/app/src/main/res/layout/activity_view_user_detail.xml b/app/src/main/res/layout/activity_view_user_detail.xml index 8b2e3546..4539f50a 100644 --- a/app/src/main/res/layout/activity_view_user_detail.xml +++ b/app/src/main/res/layout/activity_view_user_detail.xml @@ -5,7 +5,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:id="@+id/coordinator_layout_view_user_detail_activity" - android:background="?attr/backgroundColor" tools:application=".ViewUserDetailActivity"> @@ -58,8 +55,7 @@ android:paddingTop="36dp" android:paddingStart="16dp" android:paddingEnd="16dp" - android:layout_below="@id/banner_image_view_view_user_detail_activity" - android:background="?attr/backgroundColor"> + android:layout_below="@id/banner_image_view_view_user_detail_activity"> @@ -109,7 +103,6 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_gravity="bottom" - android:background="?attr/toolbarAndTabBackgroundColor" app:layout_scrollFlags="scroll|enterAlways" app:tabGravity="fill" app:tabMode="fixed" diff --git a/app/src/main/res/layout/app_bar_main.xml b/app/src/main/res/layout/app_bar_main.xml index b1d9b330..bcc7afb8 100644 --- a/app/src/main/res/layout/app_bar_main.xml +++ b/app/src/main/res/layout/app_bar_main.xml @@ -11,7 +11,6 @@ android:id="@+id/appbar_layout_main_activity" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?attr/toolbarAndTabBackgroundColor" android:theme="@style/AppTheme.AppBarOverlay"> @@ -62,7 +57,6 @@ android:layout_height="wrap_content" android:layout_gravity="bottom" android:visibility="gone" - app:backgroundTint="?attr/backgroundColor" app:fabAlignmentMode="center"> diff --git a/app/src/main/res/layout/fragment_flair_bottom_sheet.xml b/app/src/main/res/layout/fragment_flair_bottom_sheet.xml index 4cec7313..edd8ad20 100644 --- a/app/src/main/res/layout/fragment_flair_bottom_sheet.xml +++ b/app/src/main/res/layout/fragment_flair_bottom_sheet.xml @@ -4,7 +4,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:orientation="vertical" - android:background="?attr/backgroundColor" tools:application=".FlairBottomSheetFragment"> + android:tint="@android:color/tab_indicator_text" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_footer_error.xml b/app/src/main/res/layout/item_footer_error.xml index fba52052..c0278ca9 100644 --- a/app/src/main/res/layout/item_footer_error.xml +++ b/app/src/main/res/layout/item_footer_error.xml @@ -22,7 +22,6 @@ android:layout_height="wrap_content" android:layout_alignParentEnd="true" android:layout_centerVertical="true" - android:backgroundTint="?attr/colorPrimaryLightTheme" android:textColor="@android:color/white" android:text="@string/retry" android:textSize="?attr/font_default" /> diff --git a/app/src/main/res/layout/item_load_comments.xml b/app/src/main/res/layout/item_load_comments.xml index 058db8f1..1df3566f 100644 --- a/app/src/main/res/layout/item_load_comments.xml +++ b/app/src/main/res/layout/item_load_comments.xml @@ -12,7 +12,6 @@ android:layout_margin="16dp" app:mlpb_progress_stoke_width="3dp" app:mlpb_progress_color="?attr/colorAccent" - app:mlpb_background_color="?attr/circularProgressBarBackground" android:layout_gravity="center_horizontal"/> \ No newline at end of file diff --git a/app/src/main/res/layout/item_load_more_comments_placeholder.xml b/app/src/main/res/layout/item_load_more_comments_placeholder.xml index fc33b062..d801a867 100644 --- a/app/src/main/res/layout/item_load_more_comments_placeholder.xml +++ b/app/src/main/res/layout/item_load_more_comments_placeholder.xml @@ -30,7 +30,6 @@ android:id="@+id/divider_item_load_more_comments_placeholder" android:layout_width="match_parent" android:layout_height="1dp" - android:background="?attr/dividerColor" android:visibility="gone" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_nav_drawer_divider.xml b/app/src/main/res/layout/item_nav_drawer_divider.xml index c27b4d55..7f641a96 100644 --- a/app/src/main/res/layout/item_nav_drawer_divider.xml +++ b/app/src/main/res/layout/item_nav_drawer_divider.xml @@ -1,5 +1,4 @@ \ No newline at end of file + android:layout_height="1dp" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_post.xml b/app/src/main/res/layout/item_post.xml index 7e1e25cc..b2030d63 100644 --- a/app/src/main/res/layout/item_post.xml +++ b/app/src/main/res/layout/item_post.xml @@ -36,7 +36,6 @@ android:layout_gravity="center" android:layout_marginStart="16dp" android:layout_marginEnd="8dp" - android:textColor="?attr/subreddit" android:textSize="?attr/font_default" app:layout_constraintBottom_toTopOf="@id/user_text_view_item_post" app:layout_constraintStart_toEndOf="@id/icon_gif_image_view_item_post" @@ -49,7 +48,6 @@ android:layout_height="wrap_content" android:layout_marginStart="16dp" android:layout_marginEnd="8dp" - android:textColor="?attr/username" android:textSize="?attr/font_default" android:maxLines="2" android:ellipsize="end" @@ -64,7 +62,6 @@ android:layout_width="24dp" android:layout_height="24dp" android:layout_marginEnd="8dp" - android:tint="?attr/stickiedPost" android:visibility="gone" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintStart_toEndOf="@id/subreddit_name_text_view_item_post" @@ -127,8 +124,6 @@ android:padding="4dp" android:textSize="?attr/font_12" android:textColor="@android:color/white" - app:lib_setRoundedBGColor="?attr/postType" - app:lib_setRoundedBorderColor="?attr/postType" app:lib_setRadius="3dp" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -144,8 +139,6 @@ android:padding="4dp" android:visibility="gone" app:lib_setRadius="3dp" - app:lib_setRoundedBGColor="?attr/spoilerColor" - app:lib_setRoundedBorderColor="?attr/spoilerColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -158,8 +151,6 @@ android:textSize="?attr/font_12" android:textColor="@android:color/white" android:visibility="gone" - app:lib_setRoundedBGColor="?attr/nsfwColor" - app:lib_setRoundedBorderColor="?attr/nsfwColor" app:lib_setRadius="3dp" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -174,8 +165,6 @@ android:padding="4dp" android:visibility="gone" app:lib_setRadius="3dp" - app:lib_setRoundedBGColor="?attr/flairColor" - app:lib_setRoundedBorderColor="?attr/flairColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -184,7 +173,6 @@ android:layout_width="24dp" android:layout_height="24dp" android:src="@drawable/ic_archive_outline" - android:tint="?attr/archivedTint" android:visibility="gone" /> @@ -131,8 +128,6 @@ android:textSize="?attr/font_10" android:visibility="gone" app:lib_setRadius="3dp" - app:lib_setRoundedBGColor="?attr/spoilerColor" - app:lib_setRoundedBorderColor="?attr/spoilerColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -146,8 +141,6 @@ android:textSize="?attr/font_10" android:visibility="gone" app:lib_setRadius="3dp" - app:lib_setRoundedBGColor="?attr/nsfwColor" - app:lib_setRoundedBorderColor="?attr/nsfwColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -161,8 +154,6 @@ android:textSize="?attr/font_10" android:visibility="gone" app:lib_setRadius="3dp" - app:lib_setRoundedBGColor="?attr/flairColor" - app:lib_setRoundedBorderColor="?attr/flairColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -171,7 +162,6 @@ android:layout_width="24dp" android:layout_height="24dp" android:src="@drawable/ic_archive_outline" - android:tint="?attr/archivedTint" android:visibility="gone" /> + android:layout_height="1dp" /> diff --git a/app/src/main/res/layout/item_post_detail.xml b/app/src/main/res/layout/item_post_detail.xml index 61cf7399..ce515feb 100644 --- a/app/src/main/res/layout/item_post_detail.xml +++ b/app/src/main/res/layout/item_post_detail.xml @@ -26,7 +26,6 @@ android:layout_height="wrap_content" android:layout_marginStart="16dp" android:layout_marginEnd="8dp" - android:textColor="?attr/subreddit" android:textSize="?attr/font_default" android:maxLines="2" android:ellipsize="end" @@ -41,7 +40,6 @@ android:layout_height="wrap_content" android:layout_marginStart="16dp" android:layout_marginEnd="8dp" - android:textColor="?attr/username" android:textSize="?attr/font_default" android:maxLines="2" android:ellipsize="end" @@ -57,7 +55,6 @@ android:layout_height="wrap_content" android:layout_marginStart="16dp" android:layout_marginEnd="8dp" - android:textColor="?attr/username" android:textSize="?attr/font_12" android:maxLines="2" android:ellipsize="end" @@ -126,8 +123,6 @@ android:padding="4dp" android:textSize="?attr/font_12" android:textColor="@android:color/white" - app:lib_setRoundedBGColor="?attr/postType" - app:lib_setRoundedBorderColor="?attr/postType" app:lib_setRadius="3dp" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -143,8 +138,6 @@ android:padding="4dp" android:visibility="gone" app:lib_setRadius="3dp" - app:lib_setRoundedBGColor="?attr/spoilerColor" - app:lib_setRoundedBorderColor="?attr/spoilerColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -157,8 +150,6 @@ android:textSize="?attr/font_12" android:textColor="@android:color/white" android:visibility="gone" - app:lib_setRoundedBGColor="?attr/nsfwColor" - app:lib_setRoundedBorderColor="?attr/nsfwColor" app:lib_setRadius="3dp" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -173,8 +164,6 @@ android:textColor="@android:color/white" android:visibility="gone" app:lib_setRadius="3dp" - app:lib_setRoundedBGColor="?attr/flairColor" - app:lib_setRoundedBorderColor="?attr/flairColor" app:lib_setRoundedView="true" app:lib_setShape="rectangle" /> @@ -183,7 +172,6 @@ android:layout_width="20dp" android:layout_height="20dp" android:src="@drawable/ic_archive_outline" - android:tint="?attr/archivedTint" android:visibility="gone" />