From 2d0675202f402bfde2ddd5f8572d1bfd5d76f91f Mon Sep 17 00:00:00 2001 From: Docile-Alligator <25734209+Docile-Alligator@users.noreply.github.com> Date: Wed, 4 Sep 2024 23:47:04 -0400 Subject: Start adding contentDescription for image views. --- .../activity_customize_comment_filter.xml | 3 ++- .../layout-land/activity_customize_post_filter.xml | 6 ++++-- .../activity_customize_comment_filter.xml | 3 ++- .../activity_customize_post_filter.xml | 6 ++++-- .../layout/activity_comment_filter_preference.xml | 1 + .../activity_comment_filter_usage_listing.xml | 1 + .../res/layout/activity_custom_theme_listing.xml | 1 + .../layout/activity_customize_comment_filter.xml | 3 ++- .../res/layout/activity_customize_post_filter.xml | 6 ++++-- app/src/main/res/layout/activity_edit_profile.xml | 2 ++ .../main/res/layout/activity_filtered_thing.xml | 1 + app/src/main/res/layout/activity_inbox.xml | 1 + app/src/main/res/layout/activity_login.xml | 1 + .../layout/activity_post_filter_application.xml | 1 + .../res/layout/activity_post_filter_preference.xml | 1 + app/src/main/res/layout/activity_post_image.xml | 5 ++++- app/src/main/res/layout/activity_post_video.xml | 2 ++ app/src/main/res/layout/activity_search.xml | 6 ++++-- app/src/main/res/values/strings.xml | 22 ++++++++++++++++++++++ 19 files changed, 60 insertions(+), 12 deletions(-) diff --git a/app/src/main/res/layout-land/activity_customize_comment_filter.xml b/app/src/main/res/layout-land/activity_customize_comment_filter.xml index b80b28e9..70adf41f 100644 --- a/app/src/main/res/layout-land/activity_customize_comment_filter.xml +++ b/app/src/main/res/layout-land/activity_customize_comment_filter.xml @@ -286,7 +286,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_comment_filter_add_user" /> diff --git a/app/src/main/res/layout-land/activity_customize_post_filter.xml b/app/src/main/res/layout-land/activity_customize_post_filter.xml index 32197519..571d72b9 100644 --- a/app/src/main/res/layout-land/activity_customize_post_filter.xml +++ b/app/src/main/res/layout-land/activity_customize_post_filter.xml @@ -661,7 +661,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_post_filter_add_subreddit" /> @@ -711,7 +712,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_post_filter_add_user" /> diff --git a/app/src/main/res/layout-sw600dp/activity_customize_comment_filter.xml b/app/src/main/res/layout-sw600dp/activity_customize_comment_filter.xml index b80b28e9..70adf41f 100644 --- a/app/src/main/res/layout-sw600dp/activity_customize_comment_filter.xml +++ b/app/src/main/res/layout-sw600dp/activity_customize_comment_filter.xml @@ -286,7 +286,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_comment_filter_add_user" /> diff --git a/app/src/main/res/layout-sw600dp/activity_customize_post_filter.xml b/app/src/main/res/layout-sw600dp/activity_customize_post_filter.xml index 32197519..571d72b9 100644 --- a/app/src/main/res/layout-sw600dp/activity_customize_post_filter.xml +++ b/app/src/main/res/layout-sw600dp/activity_customize_post_filter.xml @@ -661,7 +661,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_post_filter_add_subreddit" /> @@ -711,7 +712,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_post_filter_add_user" /> diff --git a/app/src/main/res/layout/activity_comment_filter_preference.xml b/app/src/main/res/layout/activity_comment_filter_preference.xml index 6f2b6051..d7594020 100644 --- a/app/src/main/res/layout/activity_comment_filter_preference.xml +++ b/app/src/main/res/layout/activity_comment_filter_preference.xml @@ -45,6 +45,7 @@ android:layout_height="wrap_content" android:layout_margin="@dimen/fab_margin" android:layout_gravity="bottom|end" + android:contentDescription="@string/content_description_create_comment_filter" app:backgroundTint="?attr/colorPrimaryLightTheme" app:srcCompat="@drawable/ic_add_day_night_24dp" app:tint="@android:color/white" /> diff --git a/app/src/main/res/layout/activity_comment_filter_usage_listing.xml b/app/src/main/res/layout/activity_comment_filter_usage_listing.xml index 75cfc4e3..9c6dd90a 100644 --- a/app/src/main/res/layout/activity_comment_filter_usage_listing.xml +++ b/app/src/main/res/layout/activity_comment_filter_usage_listing.xml @@ -45,6 +45,7 @@ android:layout_height="wrap_content" android:layout_margin="@dimen/fab_margin" android:layout_gravity="bottom|end" + android:contentDescription="@string/content_description_add_comment_filter_usage" app:backgroundTint="?attr/colorPrimaryLightTheme" app:srcCompat="@drawable/ic_add_day_night_24dp" app:tint="@android:color/white" /> diff --git a/app/src/main/res/layout/activity_custom_theme_listing.xml b/app/src/main/res/layout/activity_custom_theme_listing.xml index c694b6c2..e4dc1930 100644 --- a/app/src/main/res/layout/activity_custom_theme_listing.xml +++ b/app/src/main/res/layout/activity_custom_theme_listing.xml @@ -59,6 +59,7 @@ android:layout_height="wrap_content" android:layout_margin="@dimen/fab_margin" android:layout_gravity="bottom|end" + android:contentDescription="@string/content_description_create_custom_theme" app:backgroundTint="?attr/colorPrimaryLightTheme" app:srcCompat="@drawable/ic_add_day_night_24dp" app:tint="@android:color/white" /> diff --git a/app/src/main/res/layout/activity_customize_comment_filter.xml b/app/src/main/res/layout/activity_customize_comment_filter.xml index 1022e720..f8198e5f 100644 --- a/app/src/main/res/layout/activity_customize_comment_filter.xml +++ b/app/src/main/res/layout/activity_customize_comment_filter.xml @@ -271,7 +271,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_comment_filter_add_user" /> diff --git a/app/src/main/res/layout/activity_customize_post_filter.xml b/app/src/main/res/layout/activity_customize_post_filter.xml index 575bc9c0..dbbdba12 100644 --- a/app/src/main/res/layout/activity_customize_post_filter.xml +++ b/app/src/main/res/layout/activity_customize_post_filter.xml @@ -650,7 +650,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_post_filter_add_subreddit" /> @@ -700,7 +701,8 @@ android:padding="16dp" android:background="?actionBarItemBackground" android:clickable="true" - android:focusable="true" /> + android:focusable="true" + android:contentDescription="@string/content_description_post_filter_add_user" /> diff --git a/app/src/main/res/layout/activity_edit_profile.xml b/app/src/main/res/layout/activity_edit_profile.xml index 4f3ad007..c894fdc2 100644 --- a/app/src/main/res/layout/activity_edit_profile.xml +++ b/app/src/main/res/layout/activity_edit_profile.xml @@ -68,6 +68,7 @@ android:layout_margin="8dp" android:padding="8dp" android:background="@drawable/ic_dot_outline" + android:contentDescription="@string/content_description_change_banner" app:srcCompat="@drawable/ic_outline_add_a_photo_day_night_24dp" /> @@ -93,6 +94,7 @@ android:layout_gravity="center" android:padding="8dp" android:background="@drawable/ic_dot_outline" + android:contentDescription="@string/content_description_change_avatar" app:srcCompat="@drawable/ic_outline_add_a_photo_day_night_24dp" /> diff --git a/app/src/main/res/layout/activity_filtered_thing.xml b/app/src/main/res/layout/activity_filtered_thing.xml index 2632342e..4aae7921 100644 --- a/app/src/main/res/layout/activity_filtered_thing.xml +++ b/app/src/main/res/layout/activity_filtered_thing.xml @@ -45,6 +45,7 @@ android:layout_height="wrap_content" android:layout_margin="@dimen/fab_margin" android:layout_gravity="bottom|end" + android:contentDescription="@string/content_description_customize_post_filter" android:src="@drawable/ic_filter_24dp" /> \ No newline at end of file diff --git a/app/src/main/res/layout/activity_inbox.xml b/app/src/main/res/layout/activity_inbox.xml index 88c95af6..109ebafc 100644 --- a/app/src/main/res/layout/activity_inbox.xml +++ b/app/src/main/res/layout/activity_inbox.xml @@ -58,6 +58,7 @@ android:layout_height="wrap_content" android:layout_margin="@dimen/fab_margin" android:layout_gravity="bottom|end" + android:contentDescription="@string/content_description_compose_message" app:srcCompat="@drawable/ic_add_day_night_24dp" /> \ No newline at end of file diff --git a/app/src/main/res/layout/activity_login.xml b/app/src/main/res/layout/activity_login.xml index 1f7ef7c6..4c90577b 100644 --- a/app/src/main/res/layout/activity_login.xml +++ b/app/src/main/res/layout/activity_login.xml @@ -51,6 +51,7 @@ android:layout_height="wrap_content" android:layout_margin="@dimen/fab_margin" android:layout_gravity="bottom|end" + android:contentDescription="@string/content_description_alternative_login_method" android:src="@drawable/ic_login_24dp" /> diff --git a/app/src/main/res/layout/activity_post_filter_application.xml b/app/src/main/res/layout/activity_post_filter_application.xml index cac8ca4f..7bf5b068 100644 --- a/app/src/main/res/layout/activity_post_filter_application.xml +++ b/app/src/main/res/layout/activity_post_filter_application.xml @@ -47,6 +47,7 @@ android:layout_gravity="bottom|end" app:backgroundTint="?attr/colorPrimaryLightTheme" app:srcCompat="@drawable/ic_add_day_night_24dp" + android:contentDescription="@string/content_description_add_post_filter_usage" app:tint="@android:color/white" /> \ No newline at end of file diff --git a/app/src/main/res/layout/activity_post_filter_preference.xml b/app/src/main/res/layout/activity_post_filter_preference.xml index 613d0e2b..7798261b 100644 --- a/app/src/main/res/layout/activity_post_filter_preference.xml +++ b/app/src/main/res/layout/activity_post_filter_preference.xml @@ -47,6 +47,7 @@ android:layout_gravity="bottom|end" app:backgroundTint="?attr/colorPrimaryLightTheme" app:srcCompat="@drawable/ic_add_day_night_24dp" + android:contentDescription="@string/content_description_create_post_filter" app:tint="@android:color/white" /> \ No newline at end of file diff --git a/app/src/main/res/layout/activity_post_image.xml b/app/src/main/res/layout/activity_post_image.xml index 23652e08..22c9f4f0 100644 --- a/app/src/main/res/layout/activity_post_image.xml +++ b/app/src/main/res/layout/activity_post_image.xml @@ -233,6 +233,7 @@ android:layout_height="wrap_content" android:layout_margin="16dp" android:src="@drawable/ic_outline_add_a_photo_24dp" + android:contentDescription="@string/content_description_capture_photo" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@+id/select_from_library_fab_post_image_activity" app:layout_constraintHorizontal_chainStyle="spread" @@ -246,6 +247,7 @@ android:layout_height="wrap_content" android:layout_margin="16dp" android:src="@drawable/ic_outline_select_photo_24dp" + android:contentDescription="@string/content_description_select_image" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintHorizontal_chainStyle="spread" @@ -272,7 +274,8 @@ android:layout_height="wrap_content" android:adjustViewBounds="true" android:scaleType="fitStart" - android:visibility="gone" /> + android:visibility="gone" + android:contentDescription="@string/content_description_selected_image" /> diff --git a/app/src/main/res/layout/activity_post_video.xml b/app/src/main/res/layout/activity_post_video.xml index 83081e3c..f84b84fe 100644 --- a/app/src/main/res/layout/activity_post_video.xml +++ b/app/src/main/res/layout/activity_post_video.xml @@ -233,6 +233,7 @@ android:layout_height="wrap_content" android:padding="16dp" android:src="@drawable/ic_outline_add_a_photo_24dp" + android:contentDescription="@string/content_description_record_video" app:useCompatPadding="true" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@+id/select_from_library_fab_post_video_activity" @@ -246,6 +247,7 @@ android:layout_height="wrap_content" android:padding="16dp" android:src="@drawable/ic_outline_select_photo_24dp" + android:contentDescription="@string/content_description_select_video" app:useCompatPadding="true" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/activity_search.xml b/app/src/main/res/layout/activity_search.xml index 3d4d4738..62adf999 100644 --- a/app/src/main/res/layout/activity_search.xml +++ b/app/src/main/res/layout/activity_search.xml @@ -46,7 +46,8 @@ android:src="@drawable/ic_cancel_24dp" android:clickable="true" android:focusable="true" - android:background="?attr/actionBarItemBackground" /> + android:background="?attr/actionBarItemBackground" + android:contentDescription="@string/content_description_delete_texts" /> + android:background="?attr/actionBarItemBackground" + android:contentDescription="@string/content_description_handle_link" /> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index ad3098b7..49f04e0a 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -1433,4 +1433,26 @@ Comments that have a score lower than the following value will be filtered out (-1 means no restriction). Comments that have a score higher than the following value will be filtered out (-1 means no restriction). + Create comment filter + Apply comment filter to somewhere + Add a user to comment filter + Create custom theme + Create post filter + Apply post filter to somewhere + Add a subreddit to post filter + Add a user to post filter + Change banner + Change avatar + Customize post filter + Compose message + Alternative login method + Capture photo + Select image + Selected image + Record video + Select video + Delete texts + Handle link + + -- cgit v1.2.3