aboutsummaryrefslogtreecommitdiff
path: root/app (follow)
Commit message (Collapse)AuthorAgeFilesLines
* In debug, fix crash that occurs when using the camera to post an image. (#1308)cmp2023-01-241-1/+1
|
* Fix wikimode occasionally being null from the API (#1315)cmp2023-01-241-0/+8
|
* Fix is_submitter property not being present on responses from the reveddit ↵cmp2023-01-213-5/+7
| | | | | API. (#1335) Try to fix pushshift API deleted comment searching.
* Handle image posts if url contains query string (#1300)Björn Tantau2023-01-211-15/+11
| | | | | | | * Handle image posts if url contains query string Sometimes the URL to an image contains a query string, which results in Infinity showing a link instead of the image. Example: https://www.reddit.com/r/ProgrammerHumor/comments/zxsf93/like_why_the_hell_does_windows_news_leak/ * Check path for file ending instead of using regex
* Ignore NotifyDataSetChanged lint warnings for Markwon adapters (#1228)Sergei Kozelko2023-01-218-1/+8
| | | There is no "more efficient" way to update it
* Disable aspect ratio logic when it is negative (#1296)Sergei Kozelko2023-01-211-9/+11
| | | | | Gallery can set aspect ratio to -1 which would result in negative measured height. It seem that Android treats dimensions as unsigned numbers, so negative numbers actually become huge positive numbers resulting in "infinite" height. It should be noted that this change allows to disable aspect ratio logic even when some dimension is set to `wrap_content`.
* Fix keyboard not showing on Android 13.Docile-Alligator2023-01-2119-374/+134
|
* Fix gallery image height in PostGalleryTypeImageRecyclerViewAdapter.Docile-Alligator2022-12-291-2/+2
|
* Change the style of the bottom app bar.Docile-Alligator2022-12-298-194/+159
|
* Minor bugs fixed.Docile-Alligator2022-12-273-1/+2
|
* New option in fab: go to top.Docile-Alligator2022-12-2610-46/+132
|
* Fix ItemTouchHelper issue?Docile-Alligator2022-12-244-13/+0
|
* Delete unused mCommentIcon field (#1293)Sergei Kozelko2022-12-231-7/+0
|
* Delete unused isSortingComments field (#1292)Sergei Kozelko2022-12-231-22/+6
| | | Field value is always false
* Show moderator author/user colors in more places, such as post lists and ↵cmp2022-12-236-23/+72
| | | | history. Show moderator badging in post details as well as color. (#1288)
* Inject Streamable api provider instead of Retrofit instance (#1217)Sergei Kozelko2022-12-239-35/+54
| | | Low effort/high impact case. Simple change that removes Retrofit instance creation from startup path because it is used only after receiving response from Reddit. Eliminates Retrofit instance creation completely if it is not used. Also improves type safety by replacing common Retrofit type with specific api type.
* Allow importing theme as any text (#1275)Sergei Kozelko2022-12-231-7/+12
| | | | | | | | | * Allow importing theme as any text Browsers copy content as text/html and it caused theme import to fail * Coerce clipboard data to text Clipboard can have mime type of text even when it doesn't actually contain text. For example it can contain uri to text content provider. Using `coerceToText` automatically handles all cases and returns best text representation of content.
* If an author is deleted and is clicked, don't switch to view user (#1287)cmp2022-12-2310-32/+68
| | | | | * If an author is deleted and is clicked, don't switch to the view user detail activity, since it'll just error. * Fix a canStartActivity check.
* Material You tweaks.Docile-Alligator2022-12-152-8/+8
|
* Clean up NetworkModule (#1276)Sergei Kozelko2022-12-151-19/+22
| | | | | | | Rename prefixes from `provides` to `provide` Add Named annotations to all OkHttp and Retrofit providers Remove RPAN OkHttp client
* Keep the capital letteing of your Multireddit when displayed on the home bar ↵DeathPhantom772022-12-151-2/+2
| | | | tab (#1279)
* Minor UI tweaks.Docile-Alligator2022-12-104-11/+7
|
* Refactor onFetchMoreCommentFailed callback (#1263)Sergei Kozelko2022-12-091-37/+33
| | | | | Unified branches, extracted repeatedly used expressions. Fortunately both branches had the same logic, except for placeholder position hint calculation.
* Version v5.4.0-beta1. Minor bugs fixed.Docile-Alligator2022-12-041-2/+5
|
* Version v5.4.0-beta1. Add authenticator to oauth retrofit.Docile-Alligator2022-12-041-12/+2
|
* Version v5.4.0-beta1.Docile-Alligator2022-12-041-1/+1
|
* Version v5.4.0-beta1.Docile-Alligator2022-12-041-2/+2
|
* Hide more options menu item in some activities.Docile-Alligator2022-12-031-0/+7
|
* Merge remote-tracking branch 'origin/master'Docile-Alligator2022-12-036-19/+12
|\
| * Allow https redirection in ExoPlayer (#1261)scria10002022-12-036-19/+12
| |
* | Remove RPAN.Docile-Alligator2022-12-0333-1616/+1
|/
* Fix score shown inside CommentFullyCollapsedViewHolder even the score is hidden.Docile-Alligator2022-12-032-7/+2
|
* Fix placeholder position check (#1216)Sergei Kozelko2022-12-031-78/+67
| | | | | | | | | * Fix placeholder position check Because of the missed negation `placeholderPosition` could actually point to a different comment. As a result loaded comments would be displayed at a wrong position which could result in duplicated comments. * Extract placeholder search code Simple refactoring. The only notable change is that now technically `placeholderPosition` can be -1. In practice that should never happen, but I added checks anyways
* Match parent for the bottom app bar in ViewRedditGalleryImageOrGifFragment.Docile-Alligator2022-12-031-1/+1
|
* Fix bottom app bar not shown in ViewRedditGalleryImageOrGifFragment.Docile-Alligator2022-12-032-4/+5
|
* Fix a stupid bug that prevents posts from loading.Docile-Alligator2022-12-031-5/+7
|
* Notification permission.Docile-Alligator2022-12-038-16/+91
|
* Minor bugs fixed.Docile-Alligator2022-11-282-6/+4
|
* Dagger networking refactor (#1125)Kurian Vithayathil2022-11-284-253/+308
| | | | | | | | | | | | | | | | | | | | | | | | * Separate network dependency injection module - Moved network-related dependencies into a separate module - Consolidated common dependencies to save resources constructing a http client/retrofit * Separate construction of access token interceptor * Create providers for Context and Application to be injectable * Refactor AppModule and AppComponent - Use component builder to store application context and provide to modules - Optimise AppModule providers * Use component factory to add component dependencies * Updated network dependencies to singleton. Add missing OAuth base url for oauth request Co-authored-by: Kurian Vithayathil <no.reply@github.com> Co-authored-by: Docile-Alligator <25734209+Docile-Alligator@users.noreply.github.com>
* Minor bugs fixedDocile-Alligator2022-11-271-1/+1
|
* Use more precise viewholder type in PostGalleryTypeImageRecyclerViewAdapter ↵Sergei Kozelko2022-11-271-31/+27
| | | | (#1229)
* Sort type converters - part 2 (#1244)Sergei Kozelko2022-11-2710-200/+86
| | | | | | | | | | | * Use and store sort type as enum for comments * Use and store sort type as enum for posts * Use sort type enum for search * Remove unused reddit api methods These were missed in the first "sort type" pr
* Fix Imgur bug for insecure mp4 links (#1240)scria10002022-11-272-14/+22
|
* Remove unused Post fields (#1212)Sergei Kozelko2022-11-277-61/+14
| | | | | | | | | * Remove unused isHiddenInRecyclerView Post field Was used only for reads and was always false * Remove unused isHiddenManuallyByUser Post field Was only written to and read for serialization. Never used for any logic
* Store only first level replies as children (#1222)Sergei Kozelko2022-11-255-27/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Show the current image index in gallery in PostFragment. * Fixed issue where filters applied to same feed were behaving incorrectly (#1172) * Fix ItemTouchHelper and gallery swipe gesture fighting each other. * Show correct image in the gallery in ViewRedditGalleryActivity. * Swipe to view images in a gallery in Card Layout 2. * Fix gallery layout issues. * Remove `commentData` argument that is always an empty ArrayList * Return top level comments in addition to expanded comments after parsing Since 0f1c4d loading more comments loads not only first level replies, but also deeper comments. Because of this `expandedComments` can contain those deep replies if `expandChildren` is true. Adding `expandedComments` to parent causes a bug because parent's children are supposed to be only next level replies. Because of previously mentioned changes that is not true. Now expanding parent comment results in duplicate comments: one of them correctly comes from the parent of duplicated comment. The other one is shown because it is incorrectly stored in the parent of "load more comments" button. This comment separates top level comments (fist level replies) and expanded comments. `expandedComments` are still used for display, but only first level replies are added to the parent * Add debug assertion for children depth Co-authored-by: Docile-Alligator <25734209+Docile-Alligator@users.noreply.github.com> Co-authored-by: Aidan223 <110802888+Aidan223@users.noreply.github.com>
* Minor code improvements (#1218)Anatolii Afanasev2022-11-1916-83/+30
| | | | | | | | | | | | | | | | | | | * Move mAccessToken and mAccountName initialization upper * Marked INSTANCE as a volatile to be DCL compliant * fix a typo in a method name and remove redundant switch * remove redundant ifs * removed DCL on RedditDataRoomDatabase as its controlled by dagger * remove redundant ifs in PostGalleryActivity as nColumns can be either 2 or 3 only * replace MediaStore.Video.Media.IS_PENDING with MediaStore.MediaColumns.IS_PENDING * reverting simplified ifs as it going to be used in the future * reverting HistoryPostViewModel
* Remove unused download events (#1236)Sergei Kozelko2022-11-194-29/+0
| | | | | * Remove unused DownloadRedditVideoEvent * Remove unused DownloadMediaEvent
* Sort type converters (#1211)Sergei Kozelko2022-11-187-194/+135
| | | | | | | | | | | | | * Create and add to Retrofit SortTypeConverterFactory * Clean up SortType class Mark fields as final, annotate nullability * Use SortType enums as query arguments * Use optional query arguments to simplify code Retrofit ignores null values, so there is no need to remove them from arguments manually
* hide keyboard when choosing account from bottom sheet (#1231)Patrick Demers2022-11-181-0/+3
|
* New option: Settings->Interface->Comment->Comment Divider Type.Docile-Alligator2022-11-146-6/+66
|