aboutsummaryrefslogtreecommitdiff
path: root/app/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
* Add some contrast to subreddit and user toolbars. (#1170)cmp2022-11-031-0/+5
| | | | | | | | Add a gradient from the primary theme color to transparent so that if a subreddit or user profile has a very light background, the usually light text and buttons are not obscured or in some cases invisible. The gradients don't appear for immersive mode so that the app remains immersive.
* Rename confidence sort to best (#1177)Sergei Kozelko2022-11-034-49/+31
| | | | | | | | | | | | * Rename CONFIDENCE comments sort type to BEST and remove old BEST type The Reddit API supports only CONFIDENCE sort type for comments but displays it as BEST. I renamed CONFIDENCE name to Best and added a migration step for loading correct sort type. * Clean up sortType usages in ViewPostDetailFragment Removed unnecessary null checks, object creations and most case conversions
* Display comment avatar only if it is the right user (#1191)Sergei Kozelko2022-11-031-2/+10
| | | | | | | | | Condition in callback for loading avatar url is almost always true[1]. So it would load avatar even if the viewholder got bound to another comment. Ideally the solution would be to update the comment just like now, then find current position of the comment and call onItemChanged. However you cannot call onItemChanged from onBindViewHolder and that is a problem because callback can be executed synchronously. So instead we just check that viewholder is bound to some comment and that bound comment's author matches initially requested author. [1] The only case I know when it is false is when that comment got deleted and its author got replaced with "[deleted]" before the callback got executed
* add backup password below backup settings button (#1185)Patrick Demers2022-11-022-1/+3
|
* Don't pick up hyperlink text as a link (#1182)scria10002022-11-022-1/+4
|
* always mux videos when downloading (#1152)Patrick Demers2022-11-021-25/+42
| | | | | | | * mux videos with and without audio * move variable to inner scope * rename argument to catch block
* Improve wiki link handling (#1184)Patrick Demers2022-11-021-2/+12
| | | | | | | | | * handle wiki links with dashes and index wiki page * properly handle w vs wiki and links with wiki in it twice * remove beginning and end of line tokens from wiki regex * optimize wiki regex
* Rules can now show in private subreddits (#1181)Abi07112022-11-024-5/+21
| | | | | | | * Added oauth to fetching rules * Added getRulesOauth for users that are logged in Co-authored-by: Abi <u7290897@anu.edu.au>
* handle reddit.com/report as a url, not post link (#1179)Patrick Demers2022-11-021-0/+2
|
* add button to export logs to GitHub issue (#1180)Patrick Demers2022-11-023-0/+46
|
* wait to load security settings until successful authentication (#1196)Patrick Demers2022-11-022-2/+19
|
* Fix see removed comment edit wrong comment (#1192)Blahaj-Samoyed2022-11-024-14/+28
| | | | | * Fix removed comment shown in the wrong position. * Handle index out of bounds.
* fix the bug: Scroll position is lost when changing screen orientation (#1173)HuilinChen9432022-10-241-0/+49
|
* Hide Karma (#1168)Patrick Demers2022-10-224-1/+16
| | | | | | | * feature/ability to hide karma * only hide karma in nav bar * center account name vertically when not showing karma
* Add view that can lock swipe-to-close gesture (#1140)Sergei Kozelko2022-10-229-43/+114
| | | | | | | | | | | | | | | | | | | | | | Slidr works by adding its own view in the hierarchy and listening to touch events in `onInterceptTouchEvent`. Once it detects movement in the correct direction, it returns `true` and handles all the events itself. Adding scrollable view detection to Slidr would solve the problem, but it is not possible and would probably have performance impact. Fortunately Slidr does not intercept the very first event, which is ACTION_DOWN, and it reaches scrollable view. So the scrollable view itself can decide if it should disallow the swipe. This also has a performance benefit over `OnScrollChangedListener` because the listener is triggered for every scroll of every view even if the child we are interested in did not scroll. On the other hand `on(Intercept)TouchEvent` is triggered only when the view is touched. There is a possibility that swipe won't be unlocked if view never receives ACTION_UP or ACTION_CANCEL. However the docs say nothing about the probability of this happening. Anyways, one possible solution is to post a runnable that will unlock swipe soon after locking.
* Fix comment expanding logic (#1155)Sergei Kozelko2022-10-161-12/+8
| | | | | | | Child comment expanding was broken because it did not take into account children of children of children and deeper levels of comments when calculating new comment's position. Replaced with a simple tree to list conversion in pre-order.
* Fix duplicate download folders by persisting read permission (#1164)Sergei Kozelko2022-10-152-9/+8
| | | | | | | | | | | | | | * Persist read permission ACTION_OPEN_DOCUMENT_TREE grants both read and write permissions, but they are granted only until device reboot unless app persists them. Once read permission is lost, app cannot check if folders exist in DownloadMediaService. But it can still create new folders because it has write permission. This results in duplicate folders. * Remove unnecessary FLAG_GRANT_WRITE_URI_PERMISSION This flag is ignored when used with ACTION_OPEN_DOCUMENT_TREE
* Disable Copied toast on android 13+ (#1139)o13e2022-10-156-6/+18
|
* Delineate comments with hidden scores (#1147)cmp2022-10-152-37/+70
| | | | | * Delineate comments with hidden scores. * Same change for fully collapsed comments.
* Parse spoilers into nodes (#1150)Sergei Kozelko2022-10-088-188/+240
| | | | | | | | | | | | | | | | | | Implementation is inspired by already existing in Markwon image and link processing but has to work around some limitations of writing an external plugin. The first one is storing brackets ourselves. Stored brackets need to be cleared when a new block starts. Markwon does it in MarkwonInlineProcessor but there is no callback that we could use. Clearing storage from our own block parser is unreliable as it is not guaranteed to be called. Instead, every time we need to access the storage we compare current block with the last used block and clear storage if necessary. The second problem is actually a feature of Markwon that it applies spans in reverse order of calls to MarkwonVisitor#setSpansForNode. This causes other spans like links and code to be drawn over spoilers making them visible. Adding spans with a different priority doesn't help as it would require negative priority. Instead we just remove all the SpoilerSpans from the final string and add them again, so they are applied last as we want.
* Ellipsize usernames if they don't fit on one line in a fully collapsed ↵cmp2022-10-081-0/+1
| | | | comment text area. (#1148)
* Refactor and de-duplicate markdown code (#1086)Sergei Kozelko2022-10-0815-689/+502
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add todos to places that need more markdown fixes * Parse spoilers and headings in sidebar * Assign anonymous MarkwonPlugin to a variable Prepare code for a future refactoring * Assign click listener lambda to a variable Prepare code for a future refactoring * Add function for creating Markwon with full markdown All the builders had the same plugins applied to them, except for BetterLinkMovement. But it is safe to add the plugin as it just adjusts link interactions. Also some plugins are now applied in a different order but it doesn't change anything in this case. * Add function for creating Markwon with only links support * Extract UrlMenuBottomSheetFragment creation * Add functions for creating MarkwonAdapters * Replace linkify with newInstance for BetterLinkMovementMethod Because varargs weren't used, the two methods are identical
* Fix crash in debug build by using fully qualified class name for ↵Sergei Kozelko2022-09-2512-14/+14
| | | | | | | | | | layoutmanager (#1130) When the class name is relative, Android tries to resolve it against applicationId. However it does not match the package because of `.debug` suffix so it tries to load the wrong class. This results in ClassNotFoundException and a crash. Using fully qualified class name fixes it as the system can use the class name as is.
* Fix spoiler interactions with links and long clicks (#1129)Sergei Kozelko2022-09-2511-10/+135
| | | | | | | | | | | | | | | | | | * Prioritize clicks on hidden spoilers over links Extend BetterLinkMovementMethod to override selection of span that will be touched and give spoilers and links following priorities: 1. Hidden spoiler 2. Non-spoiler span (i.e. link) 3. Shown spoiler #609 * Ignore long clicks on spoilers Ignore long clicks if it is a SpoilerSpan. Also don't apply highlight because it breaks spoiler effect. #529
* Rewrite spoiler parsing (#1104)Sergei Kozelko2022-09-251-65/+90
| | | | | | | | | | * Rewrite spoiler parsing to properly support nested spoilers and code blocks Parse all the spoilers, ignoring spoiler brackets that intersect with code spans. Detect all the spoilers that are nested and mark them accordingly. Delete all spoiler brackets that were matched. Add SpoilerSpans for non-nested ranges. * Simplify offset calculation
* Fixed Gray Overlay in Image (#1111)MChen3212022-09-211-5/+13
| | | | | * Added a clear search bar text button * Made caption disappear/show when tapping on image and removed gray overlay when no caption.
* Fix 'Suggested Title' bug (#1120)Kurian Vithayathil2022-09-211-2/+3
| | | | | - Fixed issue where a post's suggested titles would fail to generate Co-authored-by: Kurian Vithayathil <no.reply@github.com>
* Minor bugs fixed.Docile-Alligator2022-09-212-11/+10
|
* Fix reply markdown (#1098)Sergei Kozelko2022-09-216-84/+55
| | | | | | | | | | | | | | | | | | * Display comment body the same way as post body when replying There are two views that support markdown, one of them was used to display post titles and comments, the other - post bodies. The views are configured differently even though post and comment bodies should be displayed the same way. Now post and comment bodies are displayed by the same view. * Rename extra keys from TEXT to TITLE Now these extra keys are used only by post title, reflect this in the name. * Remove markdown support from post title view * Fix reply styling Co-authored-by: Docile-Alligator <25734209+Docile-Alligator@users.noreply.github.com>
* Don't trim leading whitespaces (#1072)scria10002022-09-216-8/+24
| | | Co-authored-by: Docile-Alligator <25734209+Docile-Alligator@users.noreply.github.com>
* Allow parallel installation of debug and release versions (#636)sal0max2022-09-213-3/+6
| | | | | | * Allow parallel installation of debug and release versions ...by adding '.debug' suffix to application id * add separate app name resource for debug build
* Show OP badge on restored comment (#1016)Andrei Shpakovskiy2022-09-214-2/+17
|
* Fix memory leak on ConnectivityManager (#1066)Michael Manganiello2022-09-211-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Leak found using LeakCanary. Steps: 1. Enable the LeakCanary dependency. 1. Open the app. 1. Go to the "All" tab. 1. Open any post, and go back to the post list. Leak trace: ``` 2022-09-04 17:56:05.904 32018-32018/ml.docilealligator.infinityforreddit.debug D/LeakCanary: ┬─── │ GC Root: System class │ ├─ android.net.ConnectivityManager class │ Leaking: NO (a class is never leaking) │ ↓ static ConnectivityManager.sInstance │ ~~~~~~~~~ ├─ android.net.ConnectivityManager instance │ Leaking: UNKNOWN │ Retaining 114 B in 5 objects │ mContext instance of ml.docilealligator.infinityforreddit.activities.ViewPostDetailActivity with mDestroyed = true │ ↓ ConnectivityManager.mContext │ ~~~~~~~~ ╰→ ml.docilealligator.infinityforreddit.activities.ViewPostDetailActivity instance Leaking: YES (ObjectWatcher was watching this because ml.docilealligator.infinityforreddit.activities. ViewPostDetailActivity received Activity#onDestroy() callback and Activity#mDestroyed is true) Retaining 1.8 MB in 27752 objects key = 22e99901-9689-4f70-b88c-092a4a7efad9 watchDurationMillis = 5518 retainedDurationMillis = 517 mApplication instance of ml.docilealligator.infinityforreddit.Infinity mBase instance of androidx.appcompat.view.ContextThemeWrapper ``` Solution based on [this StackOverflow answer](https://stackoverflow.com/a/41431693)
* Start utilizing view binding (#1013)Taco2022-09-216-171/+116
|
* Version 5.3.3.Docile-Alligator2022-09-191-1/+1
|
* Update translation contributors (#1108)StephenTheMoldovan2022-09-191-1/+1
|
* delete "/" in filtering multireddit pathWladimir Kirianov2022-09-181-1/+1
|
* Update multireddit apply filter text (#712)user_7272022-09-181-1/+1
| | | | | * Update multireddit apply filter text A "/" is needed at the end of the path in order for the filter to be applied correctly to the multireddit. Also, any characters that are not lowercase will also make it not apply properly.
* Fix redgifs download issues.Docile-Alligator2022-09-1613-771/+856
|
* Use simpler DrawerLayout methods (#1015)Taco2022-09-091-3/+3
|
* refactor: Extract CopyTextBottomSheetFragment display logic (#969)Sergei Kozelko2022-09-097-39/+31
|
* Remove unnecessary uses of DrawableCompat. (#1045)Isira Seneviratne2022-09-0910-54/+38
|
* Fix markdown in rules screen (#1050)Sergei Kozelko2022-09-093-18/+63
| | | | | * Display tables in rules screen * Parse spoiler and headings in rules screen
* Added a clear search bar text button (#1063)MChen3212022-09-093-0/+32
|
* Fix memory leak on BigImageViewer (#1067)Michael Manganiello2022-09-093-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Leak found using LeakCanary. Steps: 1. Enable the LeakCanary dependency. 1. Open the app. 1. Open any post image, and go back. According to `Piasy/BigImageViewer` documentation, [Initialize section](https://github.com/Piasy/BigImageViewer/blob/9cc045e8146dc8833a487576745f17158bae4a4a/README.md#initialize), the app context must be used to avoid memory leaks. Leak trace: ``` 2022-09-04 19:51:38.154 13332-13332/ml.docilealligator.infinityforreddit.debug D/LeakCanary: ┬─── │ GC Root: Thread object │ ├─ android.os.HandlerThread instance │ Leaking: NO (PathClassLoader↓ is not leaking) │ Thread name: 'LeakCanary-Heap-Dump' │ ↓ Thread.contextClassLoader ├─ dalvik.system.PathClassLoader instance │ Leaking: NO (BigImageViewer↓ is not leaking and A ClassLoader is never leaking) │ ↓ ClassLoader.runtimeInternalObjects ├─ java.lang.Object[] array │ Leaking: NO (BigImageViewer↓ is not leaking) │ ↓ Object[257] ├─ com.github.piasy.biv.BigImageViewer class │ Leaking: NO (a class is never leaking) │ ↓ static BigImageViewer.sInstance │ ~~~~~~~~~ ├─ com.github.piasy.biv.BigImageViewer instance │ Leaking: UNKNOWN │ Retaining 969.9 kB in 14812 objects │ ↓ BigImageViewer.mImageLoader │ ~~~~~~~~~~~~ ├─ com.github.piasy.biv.loader.glide.GlideImageLoader instance │ Leaking: UNKNOWN │ Retaining 969.9 kB in 14811 objects │ ↓ GlideImageLoader.mRequestManager │ ~~~~~~~~~~~~~~~ ├─ com.bumptech.glide.RequestManager instance │ Leaking: UNKNOWN │ Retaining 969.9 kB in 14808 objects │ context instance of ml.docilealligator.infinityforreddit.activities.ViewPostDetailActivity with mDestroyed = true │ ↓ RequestManager.context │ ~~~~~~~ ╰→ ml.docilealligator.infinityforreddit.activities.ViewPostDetailActivity instance Leaking: YES (ObjectWatcher was watching this because ml.docilealligator.infinityforreddit.activities. ViewPostDetailActivity received Activity#onDestroy() callback and Activity#mDestroyed is true) Retaining 966.2 kB in 14703 objects key = f69c74cc-521e-4f6c-b5c8-8f787e27df75 watchDurationMillis = 5547 retainedDurationMillis = 541 mApplication instance of ml.docilealligator.infinityforreddit.Infinity mBase instance of androidx.appcompat.view.ContextThemeWrapper ```
* Update ExoPlayer.Docile-Alligator2022-09-0824-1930/+1302
|
* Version 5.3.1.Docile-Alligator2022-09-064-311/+9
|
* Fix stupid Redgifs API issue.Docile-Alligator2022-09-0453-119/+6557
|
* Version 5.3.0.Docile-Alligator2022-08-271-1/+1
|
* Minor bugs fixed.Docile-Alligator2022-08-261-1/+5
|
generated by cgit (git). Responsive design from responsive-cgit-css. Dark theme color palette from Dracula theme