diff options
| author | Sergei Kozelko <KozelkoS@yandex.ru> | 2022-11-25 13:13:37 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-25 13:13:37 +0000 |
| commit | d3ccaea2cc16fc0efe8cee7142cfaea10bc17135 (patch) | |
| tree | 52f2ad3df9608fa87268d29464b1ffc1a59db3b1 /app/src/main/res/menu/trending_activity.xml | |
| parent | 1abda7c6e391b66ec87d12e4e577a889ca531c2f (diff) | |
| download | infinity-for-reddit-d3ccaea2cc16fc0efe8cee7142cfaea10bc17135.tar infinity-for-reddit-d3ccaea2cc16fc0efe8cee7142cfaea10bc17135.tar.gz infinity-for-reddit-d3ccaea2cc16fc0efe8cee7142cfaea10bc17135.tar.bz2 infinity-for-reddit-d3ccaea2cc16fc0efe8cee7142cfaea10bc17135.tar.lz infinity-for-reddit-d3ccaea2cc16fc0efe8cee7142cfaea10bc17135.tar.xz infinity-for-reddit-d3ccaea2cc16fc0efe8cee7142cfaea10bc17135.tar.zst infinity-for-reddit-d3ccaea2cc16fc0efe8cee7142cfaea10bc17135.zip | |
Store only first level replies as children (#1222)
* Show the current image index in gallery in PostFragment.
* Fixed issue where filters applied to same feed were behaving incorrectly (#1172)
* Fix ItemTouchHelper and gallery swipe gesture fighting each other.
* Show correct image in the gallery in ViewRedditGalleryActivity.
* Swipe to view images in a gallery in Card Layout 2.
* Fix gallery layout issues.
* Remove `commentData` argument that is always an empty ArrayList
* Return top level comments in addition to expanded comments after parsing
Since 0f1c4d loading more comments loads not only first level replies, but also deeper comments. Because of this `expandedComments` can contain those deep replies if `expandChildren` is true. Adding `expandedComments` to parent causes a bug because parent's children are supposed to be only next level replies. Because of previously mentioned changes that is not true.
Now expanding parent comment results in duplicate comments: one of them correctly comes from the parent of duplicated comment. The other one is shown because it is incorrectly stored in the parent of "load more comments" button.
This comment separates top level comments (fist level replies) and expanded comments. `expandedComments` are still used for display, but only first level replies are added to the parent
* Add debug assertion for children depth
Co-authored-by: Docile-Alligator <25734209+Docile-Alligator@users.noreply.github.com>
Co-authored-by: Aidan223 <110802888+Aidan223@users.noreply.github.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions