diff options
author | Michael Manganiello <adamantike@users.noreply.github.com> | 2022-09-21 04:47:38 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-09-21 04:47:38 +0000 |
commit | 9fad6fc9616bc317f88433b136a79f41905134ff (patch) | |
tree | 1aee0ec299e1999f412b599f0964ca89efa53967 /.github | |
parent | 55d6078ccc4e73eab8179bd0d550bfec65720708 (diff) | |
download | infinity-for-reddit-9fad6fc9616bc317f88433b136a79f41905134ff.tar infinity-for-reddit-9fad6fc9616bc317f88433b136a79f41905134ff.tar.gz infinity-for-reddit-9fad6fc9616bc317f88433b136a79f41905134ff.tar.bz2 infinity-for-reddit-9fad6fc9616bc317f88433b136a79f41905134ff.tar.lz infinity-for-reddit-9fad6fc9616bc317f88433b136a79f41905134ff.tar.xz infinity-for-reddit-9fad6fc9616bc317f88433b136a79f41905134ff.tar.zst infinity-for-reddit-9fad6fc9616bc317f88433b136a79f41905134ff.zip |
Fix memory leak on ConnectivityManager (#1066)
Leak found using LeakCanary. Steps:
1. Enable the LeakCanary dependency.
1. Open the app.
1. Go to the "All" tab.
1. Open any post, and go back to the post list.
Leak trace:
```
2022-09-04 17:56:05.904 32018-32018/ml.docilealligator.infinityforreddit.debug D/LeakCanary:
┬───
│ GC Root: System class
│
├─ android.net.ConnectivityManager class
│ Leaking: NO (a class is never leaking)
│ ↓ static ConnectivityManager.sInstance
│ ~~~~~~~~~
├─ android.net.ConnectivityManager instance
│ Leaking: UNKNOWN
│ Retaining 114 B in 5 objects
│ mContext instance of ml.docilealligator.infinityforreddit.activities.ViewPostDetailActivity with mDestroyed = true
│ ↓ ConnectivityManager.mContext
│ ~~~~~~~~
╰→ ml.docilealligator.infinityforreddit.activities.ViewPostDetailActivity instance
Leaking: YES (ObjectWatcher was watching this because ml.docilealligator.infinityforreddit.activities.
ViewPostDetailActivity received Activity#onDestroy() callback and Activity#mDestroyed is true)
Retaining 1.8 MB in 27752 objects
key = 22e99901-9689-4f70-b88c-092a4a7efad9
watchDurationMillis = 5518
retainedDurationMillis = 517
mApplication instance of ml.docilealligator.infinityforreddit.Infinity
mBase instance of androidx.appcompat.view.ContextThemeWrapper
```
Solution based on [this StackOverflow answer](https://stackoverflow.com/a/41431693)
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions